-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table, trains after midnight #8334
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8334 +/- ##
============================================
+ Coverage 36.98% 37.05% +0.06%
Complexity 2211 2211
============================================
Files 1259 1260 +1
Lines 114565 114820 +255
Branches 3192 3223 +31
============================================
+ Hits 42374 42546 +172
- Misses 70290 70342 +52
- Partials 1901 1932 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7e2b8f5
to
7354ddf
Compare
302df29
to
74edc28
Compare
74edc28
to
244baf6
Compare
front/src/applications/operationalStudies/hooks/useSetupItineraryForTrainUpdate.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useSetupItineraryForTrainUpdate.ts
Outdated
Show resolved
Hide resolved
0fa1f84
to
4fef754
Compare
c2ef063
to
b589d6a
Compare
b589d6a
to
0fadec5
Compare
2095f60
to
dd6cf07
Compare
They are meant to define clearly what they are, and give move details when you hover your mouse over them. I don’t want to lose the info and go back to a |
4ec2add
to
e028bc7
Compare
e028bc7
to
3355564
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, great work :)
on vacation, all the changes done !
fba5654
to
5a2c9e0
Compare
Signed-off-by: Valentin Chanas <[email protected]>
No change in behavior, just testing the previous behavior of the simulation input table, when a value changes. Signed-off-by: Valentin Chanas <[email protected]>
- using lodash pick to simplify the object construction - no need to lookup twice to find the corresponding pathStep - we don’t need to create copies of the pathSteps array since we are using immer to handle immutability for us - extracting the reducer logic in buildPathStepFromSuggestedOp to be reused Signed-off-by: Valentin Chanas <[email protected]>
Signed-off-by: Valentin Chanas <[email protected]>
5a2c9e0
to
143da9a
Compare
closes #7781
We now use a different format to represent
arrival
anddeparture
inSuggestedOP
andPathStep
, an ISO duration string. The previous time string format hh:mm:ss was insufficient for distinguishing times spanning more than 24 hoursThese two types are used in different places beyond the scope of just the input/outpt, we should test everything that uses these two types